[PATCH 2/2] fixup! net: register eth class

Ahmad Fatoum a.fatoum at pengutronix.de
Thu Jun 20 05:55:48 PDT 2024


net: fix crash removing uninitiailized eth_device::list during shutdown

next currently crashes on barebox_shutdown(), because list is no longer
initialized after being replaced by classes.

Fixes: 27ed36df29b1 ("net: register eth class")
Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 include/net.h | 2 --
 net/eth.c     | 1 -
 2 files changed, 3 deletions(-)

diff --git a/include/net.h b/include/net.h
index 05d73e543f7e..a04ed5b0ab92 100644
--- a/include/net.h
+++ b/include/net.h
@@ -60,8 +60,6 @@ struct eth_device {
 	struct device *parent;
 	char *nodepath;
 
-	struct list_head list;
-
 	IPaddr_t ipaddr;
 	IPaddr_t netmask;
 	char ethaddr[6];
diff --git a/net/eth.c b/net/eth.c
index ce7d839ed113..7229530c055b 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -545,7 +545,6 @@ void eth_unregister(struct eth_device *edev)
 
 	unregister_device(&edev->dev);
 	slice_exit(&edev->slice);
-	list_del(&edev->list);
 }
 
 void led_trigger_network(enum led_trigger trigger)
-- 
2.39.2




More information about the barebox mailing list