[PATCH 01/18] ARM: i.MX8M: atf: make use of imx8m*_save_bootrom_log macros

[Ahmad Fatoum]

On 11.01.24 13:16, Marco Felsch wrote:
> On 24-01-11, Ahmad Fatoum wrote:
>> On 11.01.24 12:48, Marco Felsch wrote:
>>>  	if (IS_ENABLED(CONFIG_FIRMWARE_IMX8MN_OPTEE)) {
>>> @@ -305,9 +305,9 @@ __noreturn void imx8mq_load_and_start_image_via_tfa(void)
>>>  	const void *bl31;
>>>  	size_t bl31_size;
>>>  	void *bl33 = (void *)MX8M_ATF_BL33_BASE_ADDR;
>>> -	unsigned long endmem = MX8M_DDR_CSD1_BASE_ADDR + imx8m_barebox_earlymem_size(16);
>>> +	unsigned long endmem = MX8M_DDR_CSD1_BASE_ADDR + imx8m_barebox_earlymem_size(32);
>>
>> Why this change?
> 
> Because the ddr-bandwidth for i.MX8MQ is 32-bit and the usage of
> imx8mq_save_bootrom_log() will fix this as well.

Ah, you even mention it in the commit message even.

Reviewed-by: Ahmad Fatoum <a.fatoum at pengutronix.de>

Thanks,
Ahmad

> 
> Regards,
>   Marco
> 
>>
>>>  
>>> -	imx8m_save_bootrom_log((void *)arm_mem_scratch(endmem));
>>> +	imx8mq_save_bootrom_log();
>>>  	imx8mq_load_bl33(bl33);
>>>  
>>>  	if (IS_ENABLED(CONFIG_FIRMWARE_IMX8MQ_OPTEE)) {
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |