[PATCH 5/8] commands: mmc: deprecate -c option

Marco Felsch m.felsch at pengutronix.de
Tue Nov 14 05:30:04 PST 2023


Deprecate the -c options since it's now more error prone in case both
the "enhanced area" and the "write reliability" feature should be
enabled. Instead users should use the separate "partition_complete"
command to make it more clear.

Signed-off-by: Marco Felsch <m.felsch at pengutronix.de>
---
 commands/mmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/commands/mmc.c b/commands/mmc.c
index 4e7d03231023..4259dbb763d1 100644
--- a/commands/mmc.c
+++ b/commands/mmc.c
@@ -95,6 +95,7 @@ static int do_mmc_enh_area(int argc, char *argv[])
 	while ((opt = getopt(argc, argv, "c")) > 0) {
 		switch (opt) {
 		case 'c':
+			printf("Use -c to complete the partitioning is deprecated, use separate partition_complete command instead\n");
 			set_completed = 1;
 			break;
 		}
@@ -283,7 +284,7 @@ BAREBOX_CMD_HELP_TEXT("")
 BAREBOX_CMD_HELP_TEXT("The subcommand enh_area creates an enhanced area of")
 BAREBOX_CMD_HELP_TEXT("maximal size.")
 BAREBOX_CMD_HELP_TEXT("Note, with -c this is an irreversible action.")
-BAREBOX_CMD_HELP_OPT("-c", "complete partitioning")
+BAREBOX_CMD_HELP_OPT("-c", "complete partitioning (deprecated)")
 BAREBOX_CMD_HELP_TEXT("")
 BAREBOX_CMD_HELP_TEXT("The subcommand write_reliability enable write reliability")
 BAREBOX_CMD_HELP_TEXT("")
-- 
2.39.2




More information about the barebox mailing list