[PATCH 3/8] mci: Add dwcmshc-sdhci driver

Sam Ravnborg sam at ravnborg.org
Mon Jul 10 12:47:03 PDT 2023


Hi Jules.

On Mon, Jul 10, 2023 at 07:23:30PM +0200, Jules Maselbas wrote:
> This driver initially started as a modification of dove-sdhci driver,
> it has been heavily reworked to be closer to rockchip-dwcmshc-sdhci by
> using more common sdhci code.
> 
> Signed-off-by: Jules Maselbas <jmaselbas at kalray.eu>
> ---
>  drivers/mci/Kconfig         |   8 +
>  drivers/mci/Makefile        |   1 +
>  drivers/mci/dwcmshc-sdhci.c | 520 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 529 insertions(+)
>  create mode 100644 drivers/mci/dwcmshc-sdhci.c

Unless there are good reasons that I miss you could squash this with
patch 8. It looks funny that you add a driver and then delete a lot of
code because you updated some infrastructure later.

This is to have a clean git history, which one could always ague about.

	Sam



More information about the barebox mailing list