[PATCH 4/5] ARM: novena: Read Ethernet MAC address from EEPROM

[Ahmad Fatoum]

On 25.01.23 15:28, John Watts wrote:
> On Wed, Jan 25, 2023 at 03:16:05PM +0100, Ahmad Fatoum wrote:
>> We could add the binding to the barebox AT24/AT25 driver. We'll need
>> to make sure we don't fail the probe in the error path as not to
>> break existing users. Fortunately, with deep probe, we will
>> have no -EPROBE_DEFER that would complicate this.
> 
> I'm really not sure if specifying the regulator (that should always be on) for
> every possible node is a good idea. I'd need to add -supply properties to:
> 
> - USB
> - Sata
> - HDMI
> - SD cards
> - Ethernet
> - PCIe
> - FPGA
> - I2C
> - UART

What voltage does your UART require that you don't already have when
your SoC is powered up? anyways, I still see utility in observing
the vcc-supply upstream bindings for EEPROMs.

> 
> Some regulators even require multiple inputs such as 3v and 5v delayed.

Add an of_devices_ensure_probed_by_property("regulator-boot-enabled") or
something to the start of your machine's board driver then.

> 
> John.
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |