[PATCH v2 1/1] ARM: i.MX8M: fix typo in function call

Ahmad Fatoum a.fatoum at pengutronix.de
Wed Jan 11 02:20:29 PST 2023


On 11.01.23 11:01, Johannes Schneider wrote:
> Signed-off-by: Johannes Schneider <johannes.schneider at leica-geosystems.com>

Please add commit messages. Even for seemingly trivial changes, there
is always something that can be explained, e.g.

"While both functions are equivalent, it looks out-of-place to use
 the imx8mm_ variant in an i.MX8MN board's code and in future we may
 elect to configure clocking differently on the i.MX8MP."

Which brings us to:

> -	imx8mm_early_clock_init();
> +	imx8mp_early_clock_init();

Did you compile-test this? There's no imx8mp_early_clock_init defined..

>  	imx8m_ccgr_clock_enable(IMX8M_CCM_CCGR_I2C1);
>  
>  	i2c = imx8m_i2c_early_init(IOMEM(MX8MP_I2C1_BASE_ADDR));

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list