[PATCH] regulator: fix memory leak

Andrej Picej andrej.picej at norik.com
Tue Mar 1 01:01:55 PST 2022


On 1. 03. 22 09:47, Sascha Hauer wrote:
> On Tue, Mar 01, 2022 at 09:21:34AM +0100, Andrej Picej wrote:
>> Gentle ping. The patch was probably missed as is was send as an reply to
>> Trent's memory leak find.
>>
>> On 19. 11. 21 14:06, Andrej Picej wrote:
>>> Fix memory leak of propname.
>>>
>>> Signed-off-by: Andrej Picej <andrej.picej at norik.com>
>>> ---
>>>    drivers/regulator/core.c | 6 ++++--
>>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
>>> index 097f7d779..c5cb9ee34 100644
>>> --- a/drivers/regulator/core.c
>>> +++ b/drivers/regulator/core.c
>>> @@ -231,8 +231,10 @@ static struct regulator_internal *of_regulator_get(struct device_d *dev, const c
>>>    	}
>>>    	ret = of_device_ensure_probed(node);
>>> -	if (ret)
>>> -		return ERR_PTR(ret);
>>> +	if (ret) {
>>> +		ri = ERR_PTR(ret);
>>> +		goto out;
>>> +	}
> 
> This conflicts with b720625659 ("regulator: allow use of dummy regulator").
> I fixed this up, see the result in next.

Ohh, ok. That was fast.

Thanks.
Andrej



More information about the barebox mailing list