[PATCH] regulator: fix memory leak

Sascha Hauer sha at pengutronix.de
Tue Mar 1 00:47:58 PST 2022


On Tue, Mar 01, 2022 at 09:21:34AM +0100, Andrej Picej wrote:
> Gentle ping. The patch was probably missed as is was send as an reply to
> Trent's memory leak find.
> 
> On 19. 11. 21 14:06, Andrej Picej wrote:
> > Fix memory leak of propname.
> > 
> > Signed-off-by: Andrej Picej <andrej.picej at norik.com>
> > ---
> >   drivers/regulator/core.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> > index 097f7d779..c5cb9ee34 100644
> > --- a/drivers/regulator/core.c
> > +++ b/drivers/regulator/core.c
> > @@ -231,8 +231,10 @@ static struct regulator_internal *of_regulator_get(struct device_d *dev, const c
> >   	}
> >   	ret = of_device_ensure_probed(node);
> > -	if (ret)
> > -		return ERR_PTR(ret);
> > +	if (ret) {
> > +		ri = ERR_PTR(ret);
> > +		goto out;
> > +	}

This conflicts with b720625659 ("regulator: allow use of dummy regulator").
I fixed this up, see the result in next.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list