[PATCH] pinctrl: stm32: replace magic values with defines for STM32_PINMODE
Ahmad Fatoum
ahmad at a3f.at
Thu Jan 13 22:59:43 PST 2022
Makes the code easier to follow and allows using the new macros in PBL
code for early pinmuxing of e.g. the debug UART.
Signed-off-by: Ahmad Fatoum <ahmad at a3f.at>
---
drivers/pinctrl/pinctrl-stm32.c | 6 +++---
include/soc/stm32/gpio.h | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-stm32.c b/drivers/pinctrl/pinctrl-stm32.c
index 9b5b04b6d6a8..ceaa4254c4d0 100644
--- a/drivers/pinctrl/pinctrl-stm32.c
+++ b/drivers/pinctrl/pinctrl-stm32.c
@@ -63,11 +63,11 @@ static inline u32 stm32_gpio_get_mode(u32 function)
{
switch (function) {
case STM32_PIN_GPIO:
- return 0;
+ return STM32_PINMODE_GPIO;
case STM32_PIN_AF(0) ... STM32_PIN_AF(15):
- return 2;
+ return STM32_PINMODE_AF;
case STM32_PIN_ANALOG:
- return 3;
+ return STM32_PINMODE_ANALOG;
}
return 0;
diff --git a/include/soc/stm32/gpio.h b/include/soc/stm32/gpio.h
index 13b492a6937c..448fb19e2ef8 100644
--- a/include/soc/stm32/gpio.h
+++ b/include/soc/stm32/gpio.h
@@ -25,6 +25,10 @@
#define STM32_PIN_AF(x) ((x) + 1)
#define STM32_PIN_ANALOG (STM32_PIN_AF(15) + 1)
+#define STM32_PINMODE_GPIO 0
+#define STM32_PINMODE_AF 2
+#define STM32_PINMODE_ANALOG 3
+
#define STM32_GPIO_PINS_PER_BANK 16
enum stm32_pin_bias { STM32_PIN_NO_BIAS, STM32_PIN_PULL_UP, STM32_PIN_PULL_DOWN };
--
2.33.0
More information about the barebox
mailing list