[PATCH master] x86: <asm/io.h>: fix outl/outsl access size

Ahmad Fatoum a.fatoum at pengutronix.de
Thu Jan 6 22:36:44 PST 2022


outl so far behaved like outb, probably due to a copy-paste error when
it was first added. We have three users in-tree for outl:

* drivers/serial/serial_ns16550_pci.c
  only for handling a Quatech qurik, which probably no one ever needed

* drivers/serial/serial_ns16550.c
  For platform drivers with a 4 byte I/O port resource. Only possible
  user is x86 and that has a 1 byte I/O port resource. Thus no one
  used this either.

* drivers/watchdog/itco_wdt.c
  Here it indeed triggers a bug, although in my testing the WDAT
  was functional without.

Fix this up so new code doesn't have to track this down.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
Cc: Steffen Trumtrar <str at pengutronix.de>
---
 arch/x86/include/asm/io.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index 0971727bc63d..23854128cb06 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -63,13 +63,13 @@ BUILDIO(l, , int)
 
 #define outb	outb
 #define outw	outw
-#define outl	outb
+#define outl	outl
 #define inb	inb
 #define inw	inw
 #define inl	inl
 #define outsb	outsb
 #define outsw	outsw
-#define outsl	outsb
+#define outsl	outsl
 #define insb	insb
 #define insw	insw
 #define insl	insl
-- 
2.20.1




More information about the barebox mailing list