[PATCH 11/11] treewide: add SPDX-License-Identifier for files without explicit license
Roland Hieber
rhi at pengutronix.de
Mon Jan 3 08:50:39 PST 2022
On Mon, Jan 03, 2022 at 01:20:53PM +0100, Uwe Kleine-König wrote:
> On Mon, Jan 03, 2022 at 01:05:39PM +0100, Ahmad Fatoum wrote:
> > diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
> > index 04fef71d7be9..fcfc0ed192e1 100644
> > --- a/arch/arm/tools/gen-mach-types
> > +++ b/arch/arm/tools/gen-mach-types
> > @@ -1,5 +1,7 @@
> > #!/bin/awk
> > #
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +#
>
> I would prefer to have the license identifier in the 2nd line. Not sure
> what the standard tells, but ISTR that in Linux the is no "empty" line,
> too.
I was stumbling over this one too, but the standard says "at or near the
top of the file" [1], so I think, this is okay.
Otherwise didn't notice anything strange while scrolling through this
series, except a few newline changes at ends of files here and there,
but I think those are okay too.
[1]: https://spdx.github.io/spdx-spec/using-SPDX-short-identifiers-in-source-files/#e2-format-for-spdx-license-identifier
> Otherwise thanks for your effort,
Yes, thank you!
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber at pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list