On 09.02.22 09:51, Uwe Kleine-König wrote:
> SHA1 is a symbol that cannot be enabled manually and all other symbols
> needing it, select it:
>
> $ git grep -B3 -E '(depends on|select) SHA1\>' HEAD
> HEAD:common/Kconfig-config MACHINE_ID
> HEAD:common/Kconfig- bool "compute unique machine-id"
> HEAD:common/Kconfig- depends on FLEXIBLE_BOOTARGS
> HEAD:common/Kconfig: depends on SHA1
> --
> HEAD:crypto/Kconfig-
> HEAD:crypto/Kconfig-config DIGEST_SHA1_GENERIC
> HEAD:crypto/Kconfig- bool "SHA1"
> HEAD:crypto/Kconfig: select SHA1
> --
> HEAD:crypto/Kconfig-config DIGEST_SHA1_ARM
> HEAD:crypto/Kconfig- tristate "SHA1 digest algorithm (ARM-asm)"
> HEAD:crypto/Kconfig- depends on ARM
> HEAD:crypto/Kconfig: select SHA1
>
> Fixes: aada84e72e15 ("common: machine_id: introduce machine id generation")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
SHA1 is selected by either DIGEST_SHA1_GENERIC or DIGEST_SHA1_ARM.
I don't think this is correct.
> ---
> common/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index e540cba7ebaa..79f6afd8de85 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1042,7 +1042,7 @@ config RESET_SOURCE
> config MACHINE_ID
> bool "compute unique machine-id"
> depends on FLEXIBLE_BOOTARGS
> - depends on SHA1
> + select SHA1
> help
> Compute a persistent machine-specific id and store it to $global.machine_id.
> The id is a hash of device-specific information added via
>
> base-commit: f1077640937f6e8139463136edff215163465599
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |