[PATCH] mci: Improve error message for non-existent vmmc regulator

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Sep 14 02:00:17 PDT 2021

There are three improvements: a) Use a already initialized device as first
parameter to dev_err() and b) indicate that the error will be ignored, and
c) downgrade to a warning.

This changes the error message from

	ERROR: <NULL>: Failed to get 'vmmc' regulator.


	WARNING: bcm2835_mci fe340000.mmc at 7e340000.of: Failed to get 'vmmc' regulator (ignored).

on a Raspberry Pi 4.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
 drivers/mci/mci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 92a73c8f1dfe..82e2f82f5377 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1920,7 +1920,7 @@ int mci_register(struct mci_host *host)
 	host->supply = regulator_get(hw_dev, "vmmc");
 	if (IS_ERR(host->supply)) {
-		dev_err(&mci->dev, "Failed to get 'vmmc' regulator.\n");
+		dev_warn(hw_dev, "Failed to get 'vmmc' regulator (ignored).\n");
 		host->supply = NULL;

More information about the barebox mailing list