[PATCH 1/2 v2] usb: dwc2: Make having a phy optional

Jules Maselbas jmaselbas at kalray.eu
Wed Oct 20 02:48:43 PDT 2021


On Wed, Oct 20, 2021 at 11:07:38AM +0200, Daniel Brát wrote:
> Hi Jules,
> On Tue, 19 Oct 2021 18:16:54 +0200, Jules Maselbas wrote:
> > I am interested in getting this modification merged. Beside I don't
> > think the dwc2 driver modification is needed, as phy_optional_get is
> > intended to return NULL when no phy are available. For me it makes
> > sense that NULL could be return by phy_optional_get when the phy
> > support is not compiled in.
> > 
> > Do you have the time to send a new patch with only this modification ?
> I apologize for not responding to this thread sooner, had a lot on my plate
That's ok

> lately. I agree that simply having the 'phy_optional_get' return NULL when
> unimplemented is better than making changes in the dwc2 driver itself and
> it makes sense in general for it to behave this ways. All the other functions
> using the phy already check for NULL anyway, so it is perfect fit.
> I submitted it as a new patch as you suggested.
nice :)


More information about the barebox mailing list