[PATCH] commands: smc: disable -c (start cpu) test option for ARMv8

Sascha Hauer sha at pengutronix.de
Tue Oct 5 04:52:17 PDT 2021


On Tue, Oct 05, 2021 at 01:36:13PM +0200, Ahmad Fatoum wrote:
> This option is meant for debugging and was only tested on an ARMv7 CPU.
> On ARMv8, the handshake times out and the code executing on the second
> CPU invokes undefined behavior by modifying the stack base from a non-
> naked function. This led so far to a warning, which went unnoticed, but
> a follow-up commit will make it an error to use arm_setup_stack on
> ARM64. Prepare for this by disabling -c usage on ARM64.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
> ---
> Please reorder before "ARM: document arm_setup_stack() pitfalls"
> ---
>  commands/smc.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list