[PATCH v2] ARM: socfpga: Set reset-names property for &mmc

Ian Abbott abbotti at mev.co.uk
Thu Nov 18 05:09:27 PST 2021


The device tree node for SoCFPGA's MMC device has the `resets =` property,
but is missing the `reset-names = "reset";` property.  This causes the
"dw_mmc" driver to output a warning:

WARNING: dw_mmc ff704000.dwmmc0 at ff704000.of: error claiming reset: Invalid argument

Add the missing `reset-names` property to the `&mmc` node in
"arch/arm/dts/socfpga.dtsi".  It probably needs fixing in the upstream
Linux device tree sources too!

Cc: Ahmad Fatoum <a.fatoum at pengutronix.de>
Cc: Steffen Trumtrar <s.trumtrar at pengutronix.de>
Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
---
v2: Updated commit message because it no longer fails to initialize the
MMC device since commit 724512bbac14 ("mci: dw_mmc: make reset control
optional again").

 arch/arm/dts/socfpga.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/socfpga.dtsi b/arch/arm/dts/socfpga.dtsi
index 7789c9d3b5..56dbf0b97d 100644
--- a/arch/arm/dts/socfpga.dtsi
+++ b/arch/arm/dts/socfpga.dtsi
@@ -4,6 +4,10 @@
 	};
 };
 
+&mmc {
+	reset-names = "reset";
+};
+
 &watchdog0 {
 	resets = <&rst L4WD0_RESET>;
 };
-- 
2.33.0




More information about the barebox mailing list