[PATCH] ARM: socfpga: Set reset-names property for &mmc
abbotti at mev.co.uk
Tue Nov 2 02:59:38 PDT 2021
On 02/11/2021 08:01, Sascha Hauer wrote:
> On Mon, Nov 01, 2021 at 05:40:53PM +0000, Ian Abbott wrote:
>> Since commit 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC
>> compatibles"), the dw_mmc driver requires a reset line called "reset".
>> The slightly earlier commit a3cf324593ea ("mci: dw_mmc: add optional
>> reset line") introduced the reset line support, but made it optional.
>> The device tree node for SoCFPGA's MMC device has the "resets" property,
>> but is missing the "reset-names" property, so MMC no longer works.
>> Barebox produces the error message:
>> ERROR: dw_mmc ff704000.dwmmc0 at ff704000.of: probe failed: Invalid argument
>> Add the missing "reset-names" property to the "&mmc" node in
>> "arch/arm/dts/socfpga.dtsi". It probably needs fixing in the upstream
>> Linux device tree sources too!
> The reset binding lists reset-names as an optional property, so it seems
> our reset code needs fixing and not the dtsi file.
I'll resubmit the patch later with a different commit message once
things have been settled, since it seems like a good idea for the reset
line in the socfpga.dtsi to be made use of, and it doesn't seem to do
-=( Ian Abbott <abbotti at mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
More information about the barebox