[PATCH] watchdog: add option to provide fall-back restart handler

Ahmad Fatoum a.fatoum at pengutronix.de
Mon May 31 03:17:01 PDT 2021


Hi,

On 31.05.21 11:50, Sascha Hauer wrote:
> On Mon, May 31, 2021 at 09:13:19AM +0200, Ahmad Fatoum wrote:
>> Some barebox ports may have a watchdog, but no restart handler, e.g.
>> reset happens via PMIC, which has no driver yet, but watchdog controls
>> reset line going to PMIC. Accommodate such setups by allowing
>> registration of watchdog as fall back restart handler.
>>
>> As reset handling can't be disabled, this is made a default n option
>> to conserve binary size unless explicitly enabled.
> 
> Do we really need to make this optional? The binary size overhead can't
> be much more than a few bytes.

I wouldn't like, if after an update, reset silently fell back to the
watchdog instead of hanging and alerting the user that something broke.

For development, it's ok, but once I have a proper reset driver, I want
either that or an error message IMO.

Cheers,
Ahmad

> 
> Sascha
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list