[PATCH] driver: have dev_set_name() return 0 on success

Ahmad Fatoum ahmad at a3f.at
Sat May 29 01:29:53 PDT 2021


Align the return code with Linux, where the function returns 0, not the
device name length on success. No functional change, as no one checks
the error code anyway.

Signed-off-by: Ahmad Fatoum <ahmad at a3f.at>
---
 drivers/base/driver.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index f60533c59eb1..1fa3f6c6fac0 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -480,9 +480,7 @@ int dev_set_name(struct device_d *dev, const char *fmt, ...)
 	 */
 	free(oldname);
 
-	WARN_ON(err < 0);
-
-	return err;
+	return WARN_ON(err < 0) ? err : 0;
 }
 EXPORT_SYMBOL_GPL(dev_set_name);
 
-- 
2.31.1




More information about the barebox mailing list