[PATCH 6/7] fixup! phy: Rockchip: Add driver for usb2phy

Sascha Hauer s.hauer at pengutronix.de
Mon Jun 21 23:47:10 PDT 2021


---
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 5c7d6ddb72..bb1a5c747e 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -333,8 +333,7 @@ static const struct clk_ops rockchip_usb2phy_clkout_ops = {
 	.recalc_rate = rockchip_usb2phy_clk480m_recalc_rate,
 };
 
-static int
-rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)
+static int rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)
 {
 	struct device_node *node = rphy->dev->device_node;
 	struct clk_init_data init = {};
@@ -359,7 +358,6 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)
 
 	rphy->clk480m_hw.init = &init;
 
-	/* register the clock */
 	rphy->clk480m = clk_register(rphy->dev, &rphy->clk480m_hw);
 	if (IS_ERR(rphy->clk480m)) {
 		ret = PTR_ERR(rphy->clk480m);
@@ -391,16 +389,13 @@ static int rockchip_usb2phy_probe(struct device_d *dev)
 
 	rphy->dev = dev;
 
-	rphy->grf_base = syscon_regmap_lookup_by_phandle(np,
-							"rockchip,usbgrf");
+	rphy->grf_base = syscon_regmap_lookup_by_phandle(np, "rockchip,usbgrf");
 	if (IS_ERR(rphy->grf_base))
 		return PTR_ERR(rphy->grf_base);
 
 	phy_cfgs = device_get_match_data(dev);
-	if (!phy_cfgs) {
-		dev_err(dev, "unable to get phy_cfgs\n");
+	if (!phy_cfgs)
 		return -EINVAL;
-	}
 
 	iores = dev_request_mem_resource(dev, 0);
 	if (IS_ERR(iores)) {
-- 
2.29.2




More information about the barebox mailing list