[PATCH] fixup! of: overlay: do not parse phandles as properties

Marco Felsch m.felsch at pengutronix.de
Wed Jan 13 12:12:58 EST 2021


On 21-01-13 18:00, Rouven Czerwinski wrote:
> This breaks the eventual fixup of phandles into the linux device tree.
> Fix this by also keeping the phandle properties in the DT.
> ---
>  drivers/of/overlay.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index 0bebe26e39..d7695726fc 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -60,7 +60,6 @@ static int of_overlay_apply(struct device_node *target,
>  
>  		if (of_prop_cmp(prop->name, "phandle") == 0) {
>  			target->phandle = be32_to_cpup(prop->value);
> -			continue;
>  		}

Nit:

We could also remove the {} so it's becoming a two-liner :)

Regards,
  Marco

>  
>  		err = of_set_property(target, prop->name, prop->value,
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list