[PATCH 1/4] treewide: include <linux/math64.h> wrapper instead of <asm-generic/div64.h>

Sascha Hauer sha at pengutronix.de
Thu Feb 18 04:24:53 EST 2021


On Tue, Feb 16, 2021 at 07:57:34PM +0100, Ahmad Fatoum wrote:
> <asm-generic/div64.h> isn't meant for direct usage as <asm/div64.h> may
> override this on a per-architecture basis. We don't do that currently,
> but in the future we might. Include the <linux/math64.h> instead.
> 
> No functional change.

This breaks rk3188_defconfig:

config:     arm              rk3188_defconfig
In file included from drivers/clk/rockchip/clk-pll.c:7:
include/linux/math64.h:303:8: error: unknown type name '__always_inline'
  303 | static __always_inline u32
      |        ^~~~~~~~~~~~~~~
include/linux/math64.h:304:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__iter_div_u64_rem'
  304 | __iter_div_u64_rem(u64 dividend, u32 divisor, u64 *remainder)
      | ^~~~~~~~~~~~~~~~~~
make[3]: *** [/ptx/work/WORK_EIHEI/sha/backup/barebox/barebox-maintainer-utils/barebox/scripts/Makefile.build:141: drivers/clk/rockchip/clk-pll.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/ptx/work/WORK_EIHEI/sha/backup/barebox/barebox-maintainer-utils/barebox/scripts/Makefile.build:275: drivers/clk/rockchip] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/ptx/work/WORK_EIHEI/sha/backup/barebox/barebox-maintainer-utils/barebox/scripts/Makefile.build:275: drivers/clk] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:925: drivers] Error 2
make: *** Waiting for unfinished jobs....

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list