[RFC PATCH 3/7] bootm: add kexec ELF support

Sascha Hauer s.hauer at pengutronix.de
Thu May 3 22:54:08 PDT 2018


On Sun, Apr 29, 2018 at 03:09:03PM +0200, Oleksij Rempel wrote:
> +static int do_bootm_elf(struct image_data *data)
> +{
> +	kexec_load_bootm_data(data);
> +
> +	reboot(LINUX_REBOOT_CMD_KEXEC, data);
> +
> +	return -ERESTARTSYS;
> +}
> +

I can't really judge this series. This is the only thing I stumbled
upon: I see no reason to name the architecture specific kexec function
'reboot'. I would expect some kexec specific name, like arch_kexec or
similar.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list