[RFC PATCH v2 6/8] ratp: use xstrndup() instead of a custom xmemdup_add_zero()
Aleksander Morgado
aleksander at aleksander.es
Thu Feb 8 05:22:59 PST 2018
The console operations done via RATP expect strings, so just use
xstrndup() instead of defining a custom method.
Signed-off-by: Aleksander Morgado <aleksander at aleksander.es>
---
common/ratp/ratp.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/common/ratp/ratp.c b/common/ratp/ratp.c
index 1e9c65179..fae9cec5b 100644
--- a/common/ratp/ratp.c
+++ b/common/ratp/ratp.c
@@ -132,17 +132,6 @@ static int console_send(struct ratp *r, void *pkt, int len)
return 0;
}
-static void *xmemdup_add_zero(const void *buf, int len)
-{
- void *ret;
-
- ret = xzalloc(len + 1);
- *(uint8_t *)(ret + len) = 0;
- memcpy(ret, buf, len);
-
- return ret;
-}
-
static void ratp_queue_console_tx(struct ratp_ctx *ctx)
{
u8 buf[255];
@@ -220,7 +209,7 @@ static int ratp_bb_dispatch(struct ratp_ctx *ctx, const void *buf, int len)
if (!IS_ENABLED(CONFIG_CONSOLE_RATP) || ratp_command)
return 0;
- ratp_command = xmemdup_add_zero(&rbb->data, dlen);
+ ratp_command = xstrndup((const char *)rbb->data, dlen);
ratp_ctx = ctx;
pr_debug("got command: %s\n", ratp_command);
--
2.15.1
More information about the barebox
mailing list