[PATCH 4/4] usb-nop-xceiv: Add support for 'reset-gpios' binding
Andrey Smirnov
andrew.smirnov at gmail.com
Tue May 23 17:17:45 PDT 2017
On Mon, May 22, 2017 at 11:55 PM, Nikita Yushchenko
<nikita.yoush at cogentembedded.com> wrote:
>> +
>> + if (gpio_is_valid(nopphy->reset)) {
>> + /*
>> + * Let's wait for 100 ms before deasserting reset line
>> + */
>> + mdelay(100);
>> + gpio_direction_output(nopphy->reset, 0);
>> + }
>
> Why not gpio_set_value() here? Direction is already configured at this
> stage.
No reason, really. I'll fix it in v2.
Thanks,
Andrey Smirnov
More information about the barebox
mailing list