problem configuring backlight brightness levels in device tree
iw3gtf at arcor.de
iw3gtf at arcor.de
Mon Jul 11 05:24:50 PDT 2016
Hi,
I was trying to configure a pwm backlight on an embedded arm board
and I think I've found a minor problem.
In the source file 'drivers/video/backlight-pwm.c', in the function pwm_backlight_parse_dt()
you set the number of brightness values to:
pwm_backlight->backlight.brightness_max = length / sizeof(u32);
and then loop through the array with:
for (i = 0; i <= pwm_backlight->backlight.brightness_max; i++)
to find the max of the array.
I think the '<=' should be a '<' otherwise you access an uninitialized value
one past the end of the array; this actually does not directly crash barebox
but the whole brightness values are scaled wrong.
giorgio
Giorgio, iw3gtf at arcor.de
More information about the barebox
mailing list