[PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Sat Mar 28 13:07:23 PDT 2015
- Previous message: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
- Next message: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
please write a better commit
it’s a coding style issue not a fixup
and here more a typo
Fixup means a BUG
Best Regards,
J.
> On Mar 28, 2015, at 12:23 AM, Antony Pavlov <antonynpavlov at gmail.com> wrote:
>
> ---
> commands/hashsum.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/hashsum.c b/commands/hashsum.c
> index e2dc70e..8d3694f 100644
> --- a/commands/hashsum.c
> +++ b/commands/hashsum.c
> @@ -36,7 +36,7 @@ static int do_hash(char *algo, int argc, char *argv[])
> size_t keylen = 0;
> int opt, ret;
>
> - while((opt = getopt(argc, argv, "h:")) > 0) {
> + while ((opt = getopt(argc, argv, "h:")) > 0) {
> switch(opt) {
> case 'h':
> key = optarg;
> --
> 2.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
- Previous message: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
- Next message: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the barebox
mailing list