[PATCH 2/2] remove unnecessary device pointer argument

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Mar 4 08:24:57 PST 2015


> On Mar 4, 2015, at 6:45 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> On Wed, Mar 04, 2015 at 04:43:13PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> 
>>> On Mar 4, 2015, at 3:49 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
>>> 
>>> The struct device_d * argument is not necessary, it can be retrieved from
>>> the FILE *. This adds a convenience function for doing this and removes
>>> the struct device_d * argument from the the filesystem drivers functions.
>> 
>> if you do so you should introduce fs_warn/info & co too
>> 
>> so we de not use dev_xxx version in fs
> 
> We can do that, but it's independent of these patches, right?
I’d said no as we drop the device_d we need drop dev_xxx too
to be logic

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list