[PATCH 1/5] ARM: socfpga: socrates: add qspi partitions

Steffen Trumtrar s.trumtrar at pengutronix.de
Wed Jul 15 23:47:00 PDT 2015


On Thu, Jul 16, 2015 at 08:07:23AM +0200, Sascha Hauer wrote:
> On Tue, Jul 14, 2015 at 06:16:35PM +0200, Steffen Trumtrar wrote:
> > Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
> > ---
> >  arch/arm/dts/socfpga_cyclone5_socrates.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm/dts/socfpga_cyclone5_socrates.dts b/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > index 125ad1b8502d..ccb940584b5b 100644
> > --- a/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > +++ b/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > @@ -80,5 +80,20 @@
> >  		cdns,tsd2d-ns = <50>;
> >  		cdns,tchsh-ns = <4>;
> >  		cdns,tslch-ns = <4>;
> > +
> > +		partition at 0 {
> > +			label = "prebootloader0";
> > +			reg = <0x00000 0x10000>;
> > +		};
> 
> Why prebootloader0? There's only one or not?
> 

There can be up to four and the space for the other
three is left free here. I thought prebootloader1-3 might
be added later.

> > +
> > +		partition at 1 {
> > +			label = "barebox0";
> > +			reg = <0x40000 0x80000>;
> > +		};
> 
> Same here.
> 

No good argument. So, I will have to change this :-(

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list