[PATCH] net: smc1111: fix ethernet mac setting

Sam Ravnborg sam at ravnborg.org
Sat Dec 5 14:31:06 PST 2015


On Sat, Dec 05, 2015 at 10:58:00PM +0100, Robert Jarzmik wrote:
> Even if the setting of the MAC address does work correctly, the function
> return an error.
> 
> In the former barebox version, this didn't seem to be a problem. In
> v2015.11.0 version, the "ifup eth0" command fails because of this, and
> as a consequence the network interface doesn't work.
I just spent a few minutes to audit all other set_ethaddr..() functions.
This was the only function that returns -1 in the normal case.

netx_eth.c has the following code:

     return -0;

This looks strange but is ok.

	Sam



More information about the barebox mailing list