[PATCH] net: smc1111: fix ethernet mac setting

Robert Jarzmik robert.jarzmik at free.fr
Sat Dec 5 13:58:00 PST 2015


Even if the setting of the MAC address does work correctly, the function
return an error.

In the former barebox version, this didn't seem to be a problem. In
v2015.11.0 version, the "ifup eth0" command fails because of this, and
as a consequence the network interface doesn't work.

The fix is straightforward.

Signed-off-by: Robert Jarzmik <robert.jarzmik at free.fr>
---
 drivers/net/smc91111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/smc91111.c b/drivers/net/smc91111.c
index 5ea1bc3..1199b37 100644
--- a/drivers/net/smc91111.c
+++ b/drivers/net/smc91111.c
@@ -1392,7 +1392,7 @@ static int smc91c111_set_ethaddr(struct eth_device *edev,
 		SMC_outw(priv, address, (ADDR0_REG + i));
 	}
 
-	return -1;
+	return 0;
 }
 
 #if (SMC_DEBUG > 2 )
-- 
2.1.4




More information about the barebox mailing list