[PATCH 4/6] oftree: remove dump support
Alexander Aring
alex.aring at gmail.com
Tue May 20 01:03:08 PDT 2014
On Tue, May 20, 2014 at 10:01:01AM +0200, Alexander Aring wrote:
> Hi Sascha,
>
> On Mon, May 19, 2014 at 10:59:42PM +0200, Sascha Hauer wrote:
> > This can now be done with the of_dump command.
> >
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > ---
> > commands/Kconfig | 2 --
> > commands/oftree.c | 42 +++---------------------------------------
> > 2 files changed, 3 insertions(+), 41 deletions(-)
> >
> > diff --git a/commands/Kconfig b/commands/Kconfig
> > index 381f3fd..6043cb6 100644
> > --- a/commands/Kconfig
> > +++ b/commands/Kconfig
> > @@ -1944,8 +1944,6 @@ config CMD_OFTREE
> > -l Load DTB to internal device tree
> > -p probe devices from stored device tree
> > -f free stored device tree
> > - -d dump device tree from DTB or the parsed tree if no DTB is given
> > - -n NODE specify root device NODE to dump for -d
> >
> > config CMD_TIME
> > bool "time"
> > diff --git a/commands/oftree.c b/commands/oftree.c
> > index 16648d6..db31d59 100644
> > --- a/commands/oftree.c
> > +++ b/commands/oftree.c
> > @@ -46,8 +46,6 @@ static int do_oftree(int argc, char *argv[])
> > int size;
> > int opt;
> > char *file = NULL;
> > - const char *node = "/";
> > - int dump = 0;
> > int probe = 0;
> > int load = 0;
> > int save = 0;
> > @@ -55,14 +53,11 @@ static int do_oftree(int argc, char *argv[])
> > int ret;
> > struct device_node *n, *root;
> >
> > - while ((opt = getopt(argc, argv, "dpfn:ls")) > 0) {
> > + while ((opt = getopt(argc, argv, "pfl:s:")) > 0) {
>
> Are you sure this optstring conversion is correct? Before there was
> no optargs for -l and -s.
Saw this right now in patch 6/6, sorry.
- Alex
More information about the barebox
mailing list