[PATCH 1/2] net: arc_emac: remove delay from mdio polling loop
Beniamino Galvani
b.galvani at gmail.com
Mon May 19 13:34:59 PDT 2014
Avoid unneeded delay when waiting for the completion of a mdio
operation and return as soon as possible.
Signed-off-by: Beniamino Galvani <b.galvani at gmail.com>
---
drivers/net/arc_emac.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/net/arc_emac.c b/drivers/net/arc_emac.c
index 3f6f814..23df3fd 100644
--- a/drivers/net/arc_emac.c
+++ b/drivers/net/arc_emac.c
@@ -17,6 +17,7 @@
*/
#include <asm/mmu.h>
+#include <clock.h>
#include <common.h>
#include <net.h>
#include <io.h>
@@ -342,26 +343,18 @@ static int arc_emac_set_ethaddr(struct eth_device *edev, unsigned char *mac)
return 0;
}
-/* Number of seconds we wait for "MDIO complete" flag to appear */
-#define ARC_MDIO_COMPLETE_POLL_COUNT 1
-
static int arc_mdio_complete_wait(struct arc_emac_priv *priv)
{
- unsigned int i;
-
- for (i = 0; i < ARC_MDIO_COMPLETE_POLL_COUNT * 40; i++) {
- unsigned int status = arc_reg_get(priv, R_STATUS);
-
- status &= MDIO_MASK;
+ uint64_t start = get_time_ns();
- if (status) {
+ while (!is_timeout(start, 1000 * MSECOND)) {
+ if (arc_reg_get(priv, R_STATUS) & MDIO_MASK) {
/* Reset "MDIO complete" flag */
- arc_reg_set(priv, R_STATUS, status);
+ arc_reg_set(priv, R_STATUS, MDIO_MASK);
return 0;
}
-
- mdelay(25);
}
+
return -ETIMEDOUT;
}
--
1.7.10.4
More information about the barebox
mailing list