Porting barebox to Novena: misc questions

[Jean-Christophe PLAGNIOL-VILLARD]

On 22:26 Thu 13 Mar     , Sascha Hauer wrote:
> On Thu, Mar 13, 2014 at 09:43:07PM +0100, Eric Bénard wrote:
> > Hi,
> > 
> > Le Thu, 13 Mar 2014 10:04:35 +0800,
> > Sean Cross <xobs at kosagi.com> a écrit :
> > > I've finally managed to get U-Boot's SPL to configure DDR3 and load
> > > barebox off of a FAT partition on an i.MX6DL.  I also have a barebox
> > > build with most features turned on, and I'm running into a number of
> > > problems.  barebox is able to load a zImage off of the FAT partition,
> > > set up ATAGs, and jump to it.  So I have the basics done.  But there are
> > > lots of little things that aren't working.
> > > 
> > > When I boot without an Ethernet cable plugged in, the "timeout" command
> > > takes a very long time to complete.  It generally freezes at "Hit any
> > > key to stop autoboot:  3" and tends to ignore input for around ten
> > > seconds.  How can I prevent this from happening, short of compiling out
> > > FEC support?
> > > 
> > that's very similar to what I reported here :
> > http://lists.infradead.org/pipermail/barebox/2014-February/018005.html
> > 
> > I didn't yet had time to investigate more based on Sascha's answer but
> > that's on my todo list.
> 
> Ok, got it. The following fixes this. Looking at the netconsole it seems
> some love is needed. Right now it only seems to work when port and ip
> are set in the right order.

I'm going to give a try on it too later this week

Best Regards,
J.
> 
> Sascha
> 
> --------------8<----------------------------------
> 
> From e4616cba4ec41ebc0d9e0419fd094984209ddbd1 Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer at pengutronix.de>
> Date: Thu, 13 Mar 2014 22:09:47 +0100
> Subject: [PATCH] netconsole: bail out when no connection is opened
> 
> When no connection is opened we should not call into
> the networking stack. Otherwise it can happen that we
> delay further execution until the network stack detected
> a link (or timed out bringing the link up).
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  net/netconsole.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/netconsole.c b/net/netconsole.c
> index 2ab19de..86a68e1 100644
> --- a/net/netconsole.c
> +++ b/net/netconsole.c
> @@ -81,6 +81,9 @@ static int nc_getc(struct console_device *cdev)
>  					struct nc_priv, cdev);
>  	unsigned char c;
>  
> +	if (!priv->con)
> +		return 0;
> +
>  	while (!kfifo_len(priv->fifo))
>  		net_poll();
>  
> @@ -94,6 +97,9 @@ static int nc_tstc(struct console_device *cdev)
>  	struct nc_priv *priv = container_of(cdev,
>  					struct nc_priv, cdev);
>  
> +	if (!priv->con)
> +		return 0;
> +
>  	if (priv->busy)
>  		return kfifo_len(priv->fifo) ? 1 : 0;
>  
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox