[PATCH 1/8] clocksource: add dummy software-only clocksource

[Sascha Hauer]

On Thu, Mar 13, 2014 at 09:09:28AM +0400, Antony Pavlov wrote:
> On Wed, 12 Mar 2014 21:50:41 +0100
> Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> > On Tue, Mar 11, 2014 at 01:34:34AM +0400, Antony Pavlov wrote:
> > > This driver is very handy for initial barebox porting.
> > > It was used for running barebox on DiGiC2-based camera
> > > and initial porting barebox to Loongson-1 and ar9331.
> > > 
> > > Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> > > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > > Reported-by: Alexander Aring <alex.aring at gmail.com>
> > > Reported-by: Alexander Shiyan <shc_work at mail.ru>
> > > ---
> > >  drivers/clocksource/Kconfig  |  9 +++++++
> > >  drivers/clocksource/Makefile |  1 +
> > >  drivers/clocksource/dummy.c  | 56 ++++++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 66 insertions(+)
> > > 
> > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > > index 4ef25ec..f9e00ff 100644
> > > --- a/drivers/clocksource/Kconfig
> > > +++ b/drivers/clocksource/Kconfig
> > > @@ -14,6 +14,15 @@ config CLOCKSOURCE_CLPS711X
> > >  	bool
> > >  	depends on ARCH_CLPS711X
> > >  
> > > +config CLOCKSOURCE_DUMMY
> > > +	bool "Enable dummy software-only clocksource"
> > > +	default n
> > 
> > You can drop the default n, no is the default already. Could you add
> > some help text mentioning that this clocksource is for early bringup
> > only and doesn't provide correct timing?
> 
> Ok, I'll write a help text.
> 
> Yesterday I got working davinci hardware clocksource :)
> So I have no dependency on dummy clocksource for Davinci. 
> 
> What is about the rest of davinci patches?

The rest looks fine, although I would prefer of cause if you used
devicetree for probing devices.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |