[RFC v2 2/2] [WIP] net: add initial ENC28J60 support

[Sascha Hauer]

On Mon, Jun 16, 2014 at 11:41:20AM +0400, Antony Pavlov wrote:
> ENC28J60 is a stand-alone Ethernet controller with SPI Interface.
> and integrated 10BASE-T PHY.
> 
> This driver was ported from linux-3.15.
> 
> The most notable barebox driver version changes:
>   * add device tree support;
>   * use IF_ENABLED for checking CONFIG_ENC28J60_WRITEVERIFY;
>   * add mii_bus support;
>   * rename {nolock,locked}_regw_{read,write}() to enc28j60_*_{read,write}().
> 
> TODOs:
>   * receive only one packet per enc28j60_eth_rx() call.
>   * fix empty enc28j60_init_dev;
>   * add parameter for changing debug loglevel on-the-run;
>   * ENC28J60 supports only SPI mode 0 so we have to submit
>     this information to the SPI controller explicitly.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> 
> Changes since v1:
>   * drop unused macros;
>   * use random_ether_addr();
>   * drop 'select CRC32' in Kconfig;
>   * drop MAC address generation in driver's code;
>   * rename {nolock,locked}_regw_{read,write}() to enc28j60_*_{read,write}();
>   * add mii_bus support.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>

...

> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> new file mode 100644
> index 0000000..4884854

I don't really like the headerfile leaking in from Linux just to make
this driver compile. Also I think such a fine grained network device
debugging is not so useful for barebox. So can you drop this? Otherwise
I'm fine with the driver.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |