Re: [PATCH 13/15] ARM: i.MX25: Karo TX25: Switch to devicetree support

[Alexander Shiyan]

Пятница, 31 января 2014, 15:23 +01:00 от Sascha Hauer <s.hauer at pengutronix.de>:
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
> arch/arm/boards/karo-tx25/board.c   | 130 ++++++++++--------------------------
...
> #define TX25_FEC_PWR_GPIO	IMX_GPIO_NR(4, 9)
> #define TX25_FEC_RST_GPIO	IMX_GPIO_NR(4, 7)
> 
> +static struct gpio fec_gpios[] = {
> +	{
> +		.gpio = TX25_FEC_PWR_GPIO,
> +		.flags = GPIOF_OUT_INIT_LOW,
> +		.label = "fec-pwr",
> +	}, {
> +		.gpio = TX25_FEC_RST_GPIO,
> +		.flags = GPIOF_OUT_INIT_LOW,
> +		.label = "fec-rst",
> +	},
> +};

You have added these pins to DTS in PATCH 08/15.
What a reason to setup it twice?

---