[PATCH 1/3] mci: add DSR support

[Sascha Hauer]

On Fri, Jan 10, 2014 at 12:56:59PM +0100, Markus Niebel wrote:
> Hello Sascha,
> Am 10.01.2014 12:18, wrote Sascha Hauer:
> > Hi Markus,
> > 
> > On Fri, Jan 10, 2014 at 10:29:49AM +0100, Markus Niebel wrote:
> >> From: Markus Niebel <Markus.Niebel at tqs.de>
> >>
> >> The eMMC and the SD-Card specifications describe the optional SET_DSR command.
> >> During measurements at our lab we found that some cards implementing this feature
> >> having really strong driver strengts per default. This can lead to voltage peaks
> >> above the specification of the host on signal edges for data sent from a card to
> >> the host.
> >>
> >> Since availability of a given card type may be shorter than the time a certain
> >> hardware will be produced it is useful to have support for this command (Alternative
> >> would be changing termination resistors and adapting the driver strength of the
> >> host to the used card.)
> > 
> > So not all cards support this command. Have you tested it with cards
> > that do not support it to make sure they still work? With eMMC you know
> > at board level whether or not this command is supported, but with SD
> > cards you don't.
> > 
> 
> No tests done with SD-cards (SD card spec states, that DSR can be implemented, 
> but we found no card, that implements this feature).
> 
> On the eMMC side we did tests with TQMa53 (barebox and u-boot) and TQMa6 
> (u-boot only) and also with i.MX28 based platform:
> 
> if a card does not support DSR - CMD4 is never sent
> if a card supports DSR but board does not activate the feature - CMD4 is never sent
> if a card supports DSR and board code requests the feature - CMD4 is sent with the
> configured value.
> 
> Would it be a good idea to document the feature as intended for non removable cards
> where the exact value is known?

My only concern was that this feature might be enabled on slots where
cards are used that do not support the DSR feature and do not work
anymore. As this doesn't seem to be the case I'm fine with your patch.
Adding devicetree support is a good idea though as Alexander mentioned.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |