November spi changes

[Sascha Hauer]

Hi Antony,

> 
> If I rebase Atheros 933x over barebox-2013.12.0 then I get
> "Ooops" in get_param_by_name(dev=spi, name=size)
> 
> =========================================
> Board: TP Link WR720N
> m25p80 m25p800: s25sl032p (4096 Kbytes)
> register_device: already registered spi

This seems to be your problem,

> 
> Ooops, TLB miss on load or ifetch!

This probably results from add_mtd_device() failling to check the return
value of register_device() properly.

> =========================================================
> static struct flash_platform_data spi_boot_flash_data = {
> 	.name		= "spi",
> 	.type		= "s25sl032p",
> };
> =========================================================
> 
> to
> 
> =========================================================
> static struct flash_platform_data spi_boot_flash_data = {
> 	.name		= "spi0",
> 	.type		= "s25sl032p",
> };
> =========================================================

The .name field defines the device filename under /dev. I would use
something like "spiflash0" here. "spi" or "spi0" sounds more like a spi
bus and in fact the it's already used by the spi bus.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |