Re: [PATCH 1/8] common/kallsyms.c: Fix sparse warning

Alexander Shiyan shc_work at mail.ru
Mon Feb 17 02:30:58 EST 2014


Понедельник, 17 февраля 2014, 8:25 +01:00 от Sascha Hauer <s.hauer at pengutronix.de>:
> On Sun, Feb 16, 2014 at 11:24:30AM +0400, Alexander Shiyan wrote:
> > CHECK   common/kallsyms.c
> > common/kallsyms.c:170:12: warning: symbol 'kallsyms_lookup' was not
> declared. Should it be static?
> > 
> > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> 
> Applied all, although with some of them I'm not sure whether the correct
> fix would be to actually add the declaration to a header file instead of
> making the symbol static.

You are right, but declaration may be added as they are needed.

---


More information about the barebox mailing list