Re: [PATCH 2/7] ARM: i.MX53: Add sata to devicetree

[Alexander Shiyan]

Понедельник, 10 февраля 2014, 9:33 +01:00 от Sascha Hauer <s.hauer at pengutronix.de>:
> On Sat, Feb 08, 2014 at 06:26:41PM +0400, Alexander Shiyan wrote:
> > Суббота,  8 февраля 2014, 15:16 +01:00 от Eric Bénard <eric at eukrea.com>:
> > > Signed-off-by: Eric Bénard <eric at eukrea.com>
> > > ---
> > > arch/arm/dts/imx53.dtsi | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/arch/arm/dts/imx53.dtsi b/arch/arm/dts/imx53.dtsi
> > > index 678547c..91659b8 100644
> > > --- a/arch/arm/dts/imx53.dtsi
> > > +++ b/arch/arm/dts/imx53.dtsi
> > > @@ -75,6 +75,15 @@
> > > interrupt-parent = <&tzic>;
> > > ranges;
> > > 
> > > +		sata: sata at 10000000 {
> > > +			compatible = "fsl,imx53-ahci";
> > > +			reg = <0x10000000 0x1000>;
> > > +			interrupts = <28>;
> > > +			clocks = <&clks 173>, <&clks 5>, <&clks 188>;
> > > +			clock-names = "sata", "ahb", "per";
> > > +			status = "disabled";
> > > +		};
> > 
> > Sascha, we stop changing DTS of the kernel or not?
> > What is the ultimate solution?
> 
> What do you suggest for the case above? A imx53-bb.dtsi included from
> imx53.dtsi? I think disallowing ahci support for barebox if it's not
> upstream in Linux is not a good option.

I suggest just sync imx53.dtsi from the linux-next, as a result we will have
non-modified version of kernel templates.
Change as above, makes imx53.dtsi different for kernel and barebox.
This is part of sata node from the kernel:
		sata: sata at 10000000 {
			compatible = "fsl,imx53-ahci";
			reg = <0x10000000 0x1000>;
			interrupts = <28>;
			clocks = <&clks IMX5_CLK_SATA_GATE>,
				 <&clks IMX5_CLK_SATA_REF>,
				 <&clks IMX5_CLK_AHB>;
			clock-names = "sata_gate", "sata_ref", "ahb";
			status = "disabled";
		};

---