Re: [PATCHv2 2/3] x86: Add support for IDE on the legacy I/O ports

[Alexander Shiyan]

Fri,  4 Apr 2014 20:09:46 +0200 от michel at reverze.net:
> From: Michel Stam <m.stam at fugro.nl>
> 
> ---
>  arch/x86/boards/x86_generic/generic_pc.c |   73 +++++++++++++++++++++++
>  drivers/ata/ide-sff.c                    |   94 ++++++++++++++++++++++++-----
>  drivers/ata/intf_platform_ide.c          |   33 +++++++++-
>  include/ata_drive.h                      |    1 +
>  4 files changed, 180 insertions(+), 21 deletions(-)
> 
> diff --git a/arch/x86/boards/x86_generic/generic_pc.c b/arch/x86/boards/x86_generic/generic_pc.c
> index 74a7224..895b88d 100644
> --- a/arch/x86/boards/x86_generic/generic_pc.c
> +++ b/arch/x86/boards/x86_generic/generic_pc.c
> @@ -27,6 +27,10 @@
>  #include <ns16550.h>
>  #include <linux/err.h>
>  
> +#ifdef CONFIG_DISK_INTF_PLATFORM_IDE
> +#include <platform_ide.h>
> +#endif

Uhh, do you really need to #ifdef this?

---