[PATCH 2/4] Firmware: provide a handler to program Altera FPGAs

[Sascha Hauer]

On Tue, Nov 12, 2013 at 05:03:59PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > +	if (ret != 0) {
> > +		dev_err(dev, "FPGA does not acknowledge the programming initiation\n");
> > +		if (gpio_get_value(this->nstat_gpio))
> > +			dev_err(dev, "STATUS is still high!\n");
> > +		if (gpio_get_value(this->confd_gpio))
> > +			dev_err(dev, "CONFIG DONE is still high!\n");
> > +		return ret;
> > +	}
> > +
> > +	/* arm the FPGA to await its new firmware */
> > +	gpio_set_value(this->nconfig_gpio, 1);
> no one check the return of gpio_set but we need to
> 
> on a i2c-gpio it might fail

I don't think that's necessary here. If setting gpios fails the firmware
programming will fail later anyway.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |