[PATCH 3/4] DT: Add binding for Altera FPGAs in passive-serial mode

[Sascha Hauer]

On Tue, Nov 12, 2013 at 10:21:02AM -0600, Kumar Gala wrote:
> 
> On Nov 12, 2013, at 8:31 AM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > Cc: devicetree at vger.kernel.org
> > ---
> > .../devicetree/bindings/firmware/altr,passive-serial.txt    | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > new file mode 100644
> > index 0000000..6d40c91
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > @@ -0,0 +1,13 @@
> > +Altera FPGAs in passive serial mode
> > +-----------------------------------
> > +
> > +This binding defines the control interface to Altera FPGAs in
> > +passive serial mode. This is used to upload the firmware and
> > +to start the FPGA.
> > +
> > +Required properties:
> > +- compatible: shall be "altr,passive-serial”
> 
> This doesn’t seem quite descriptive enough, easy to confuse with a serial port.

How about altr,fpga-passive-serial? Other suggestions?

> 
> > +- reg: SPI chip select
> 
> Is this a SPI device than?

Yes, it is.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |