[PATCH v2 0/6] BCM2835 / simple framebuffer support

[Sascha Hauer]

On Tue, Nov 12, 2013 at 01:14:51PM +0100, Andre Heider wrote:
> Hi Sascha,
> 
> On Wed, Nov 06, 2013 at 06:40:49PM +0100, Andre Heider wrote:
> > And yes, it works if I set fb0.enable=1 and fb0.register_simplefb=1,
> > both are 0 per default.
> > 
> > Now I wonder who/where those are supposed to get set? Is that a job for
> > the runtime environment?
> 
> if possible I'd like to make the fb work out of the box. Setting these
> two parameters to default to "1" feels wrong (and I didn't find other
> drivers to do so). Any suggestions?

Normally the policy is that a framebuffer is not enabled during
registration. This makes sense because normally the framebuffer doesn't
contain a useful picture, so users should set a picture and enable the
framebuffer afterwards to avoid flickering.

In your case the situation is different though. The display hardware is
already enabled when you enter barebox, right? In this case I suggest
that you set info->p_enable to true before calling register_framebuffer
from the bcm2835 driver. This should be the right thing to do since it
only reflects the hardware status.

Also I think you can set info->register_simplefb to true aswell in the
bcm2835 driver since on that platform this is probably a sane default.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |