[PATCH 3/3] ARM: i.mx53: Support for Voipac board. Device definition is read from Devicetree

[Sascha Hauer]

Hi Rostislav,

On Tue, Nov 05, 2013 at 03:42:07PM +0100, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy <lisovy at gmail.com>
> 
> diff --git a/arch/arm/boards/freescale-mx53-vmx53/env/config b/arch/arm/boards/freescale-mx53-vmx53/env/config
> new file mode 100644
> index 0000000..3d90172
> --- /dev/null
> +++ b/arch/arm/boards/freescale-mx53-vmx53/env/config

Why not use defenv-2?

> diff --git a/arch/arm/boards/freescale-mx53-vmx53/flash_header.c b/arch/arm/boards/freescale-mx53-vmx53/flash_header.c
> new file mode 100644
> index 0000000..a6864a6
> --- /dev/null
> +++ b/arch/arm/boards/freescale-mx53-vmx53/flash_header.c

I'm currently generating the flash images for new boards using the
imx-image tool and also generate multi board images. This is a very
flexible, though maybe hard to understand mechanism. Is this the reason
you haven't used it or were you not aware of it?
I would rather see this board taking part in this new mechanism. Are you
willing to port this over? Otherwise I could try and convert this patch,
but I would depend on you testing the result.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |