[PATCH v2 0/6] BCM2835 / simple framebuffer support

Alexander Aring alex.aring at gmail.com
Wed Nov 6 05:18:19 EST 2013


On Wed, Nov 06, 2013 at 11:02:33AM +0100, Sascha Hauer wrote:
> On Wed, Nov 06, 2013 at 11:04:02AM +0100, Alexander Aring wrote:
> > Hi Sascha,
> > 
> > On Wed, Nov 06, 2013 at 10:46:28AM +0100, Sascha Hauer wrote:
> > > Hi Andre,
> > > @@ -163,6 +163,13 @@ int register_framebuffer(struct fb_info *info)
> > >  	if (ret)
> > >  		goto err_unregister;
> > >  
> > > +	if (IS_ENABLED(CONFIG_DRIVER_VIDEO_SIMPLEFB)) {
> > > +		ret = fb_register_simplefb(info);
> > > +		if (ret)
> > > +			dev_err(&info->dev, "failed to register simplefb: %s\n",
> > > +					strerror(-ret));
> > maybe we should return ret here?
> 
> I think it's fine to continue without simplefb here. In the end the
> framebuffer works, just without simplefb.
> 
ok, thanks.

- Alex



More information about the barebox mailing list