[PATCH 0/7] Basic support for Marvell Armada 370/XP SoC

[Thomas Petazzoni]

Dear Sascha Hauer,

On Sun, 5 May 2013 08:33:18 +0200, Sascha Hauer wrote:

> > > Great work!  Very clean series.  I only have one thought.  Prafulla
> > > (u-boot kirkwood maintainer) is always asking about consolidating the
> > > kwbimage.cfg files.  The three you've submitted for the first three
> > > boards are almost (if not entirely) identical.  Before a whole bunch of
> > > boards get added, should we make a kwbimage-common.cfg or similar?
> > 
> > I'm not sure I want to make the configuration language more complicated
> > than it is already. It's already a pain to parse such a configuration
> > file in C (I would have preferred to write the kwbimage tool in Python,
> > but since all existing Barebox tools are in C, I wasn't sure a Python
> > tool would have been accepted). Adding the support for includes means
> > that you have to recursively handle includes, etc. I'm not sure I want
> > to go down this road for files that typically have between 10 to 30
> > lines.
> 
> How about using the C preprocessor for includes if they become
> necessary?

Yes, that could be one option, and certainly more reasonable than
including the include mechanism into the configuration language itself.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com