[PATCH] ARM omap hsmmc: Fix adding iobase for OMAP3

Jürgen Kilb J.Kilb at phytec.de
Mon Jan 7 10:02:17 EST 2013


Hi Sascha,

On 07.01.2013 10:23, Sascha Hauer wrote:
> Hi Jürgen,
>
> On Fri, Jan 04, 2013 at 05:13:12PM +0100, Juergen Kilb wrote:
>> Only the OMAP4 hsmmc module has an offset of 0x100 from its register
>> base address. With commit 416a991 the offset was added for all SOCs
>> which use the omap_hsmmc driver.
> The offset was present before 416a991 aswell. It seems that the device
> convenience functions introduced with bc872dbe79 did it wrong for OMAP3.
> When then the boards started using the convenience functions with
> 5a12f45 it became broken.
OK, I've not dug deeper...
> I prefer to fix this properly. Does the following fix it for you?
Yes, your patch looks better then my simple version.
Your patch fixed it for me.
You can add my "Tested-by: J.Kilb at Phytec.de" line.

thanks,
Jürgen



More information about the barebox mailing list