[PATCH] mtd: fix wrong return values in cdev read
Sascha Hauer
s.hauer at pengutronix.de
Thu Dec 19 10:21:23 EST 2013
mtd->read returns the number of bitflips as positive numbers.
Instead of returning these numbers Return -EUCLEAN when the bitflip
threshold has been reached, 0 otherwise.
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
drivers/mtd/core.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
index f63b10e..57b0fad 100644
--- a/drivers/mtd/core.c
+++ b/drivers/mtd/core.c
@@ -74,12 +74,11 @@ static ssize_t mtd_op_read(struct cdev *cdev, void* buf, size_t count,
offset, count);
ret = mtd_read(mtd, offset, count, &retlen, buf);
-
- if(ret) {
- printf("err %d\n", ret);
+ if (ret < 0)
return ret;
- }
- return retlen;
+ if (mtd->ecc_strength == 0)
+ return 0; /* device lacks ecc */
+ return ret >= mtd->bitflip_threshold ? -EUCLEAN : 0;
}
#define NOTALIGNED(x) (x & (mtd->writesize - 1)) != 0
--
1.8.5.1
More information about the barebox
mailing list